Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the licenses of dependencies #2943

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Check the licenses of dependencies #2943

merged 4 commits into from
Oct 17, 2023

Conversation

kallydev
Copy link
Contributor

@kallydev kallydev commented Oct 14, 2023

What does this change

Use github.com/google/go-licenses in GitHub Actions to check the licenses of dependencies.

What issue does it fix

Closes #2942.

Notes for the reviewer

https://github.com/kallydev/porter/actions/runs/6518629371

If we need to ignore more packages, we can use the --ignore multiple times.

go-licenses check ./... \
    --ignore github.com/xi2/xz,golang.org/x/sys/unix # https://github.com/xi2/xz/blob/master/LICENSE \
    --ignore github.com/xi2/xz,golang.org/x/sys/unix # https://github.com/xi2/xz/blob/master/LICENSE

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

Resolved #2942.

Signed-off-by: KallyDev <kallydev@gmail.com>
Signed-off-by: KallyDev <kallydev@gmail.com>
@troy0820
Copy link
Member

/azp run porter-integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: KallyDev <kallydev@gmail.com>
@kallydev kallydev requested a review from schristoff October 17, 2023 00:50
@schristoff schristoff merged commit da36569 into getporter:main Oct 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(githubactions/pipelines) Dependency License Checker
3 participants