-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature to mount host volumes #2949
Merged
schristoff
merged 9 commits into
getporter:main
from
maniSbindra:manisbindra/add-install-uninstall-local-volume-mount-feature
Feb 7, 2024
Merged
Add feature to mount host volumes #2949
schristoff
merged 9 commits into
getporter:main
from
maniSbindra:manisbindra/add-install-uninstall-local-volume-mount-feature
Feb 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes getporter#475 - Add option to mount host volume Signed-off-by: Maninderjit Bindra <maninder.bindra@gmail.com>
Signed-off-by: Maninderjit Bindra <maninder.bindra@gmail.com>
Signed-off-by: Maninderjit Bindra <maninder.bindra@gmail.com>
maniSbindra
requested review from
schristoff,
sgettys,
bdegeeter and
troy0820
as code owners
October 23, 2023 11:15
maniSbindra
changed the title
Manisbindra/add install uninstall local volume mount feature
Add feature to mount host volumes for commands like porter install and porter uninstall
Oct 23, 2023
maniSbindra
changed the title
Add feature to mount host volumes for commands like porter install and porter uninstall
Add feature to mount host volumes
Oct 23, 2023
Signed-off-by: Maninderjit Bindra <maninder.bindra@gmail.com>
/azp run porter-integration |
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Maninderjit Bindra <maninder.bindra@gmail.com>
Signed-off-by: Maninderjit Bindra <maninder.bindra@gmail.com>
This is great! I would suggest, if it's not already there, to also enable mounting through the porter config. That way you vould set up mounts you always want, for example |
/azp run porter-integration |
sgettys
reviewed
Nov 9, 2023
sgettys
reviewed
Nov 9, 2023
Signed-off-by: Maninderjit Bindra <maninder.bindra@gmail.com>
sgettys
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
This change adds flag --mount-host-volume for commands like porter install and porter uninstall, which enables making a host file system folder available inside the running container, which executes the action.
For example the following commands makes the host's $HOME/.hostfolder folder available inside the bundle (as read/write mount) at /home/nonroot/.hostfolder .
Multiple folders may be mounted. Format for adding a mount is <host path>:<container path>[:<option>]. If option is ro or not provided or invalid, then file system is mounted as read only. If option is rw then file system is mounted as read/write inside the container
What issue does it fix
Closes #475
Notes for the reviewer
This works with the docker driver. By default folders are mounted as read only.
Checklist
Reviewer Checklist