Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependcies and update go to 1.21 #2999

Merged
merged 6 commits into from
Mar 13, 2024

Conversation

troy0820
Copy link
Member

What does this change

Update dependencies to a newer version of kubernetes. This change brought in the need to update go to 1.21 which should be okay being that go 1.22 came out.

  • Update k8s dependencies
  • Update go to 1.21

What issue does it fix

N/A

Notes for the reviewer

Put any questions or notes for the reviewer here.

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
@troy0820 troy0820 force-pushed the troy0820/update-deps branch from 83602dd to 4e50e12 Compare February 14, 2024 19:28
Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
@troy0820 troy0820 force-pushed the troy0820/update-deps branch from 48dd304 to 77344ba Compare February 14, 2024 21:16
@schristoff
Copy link
Member

looks all green, all good to merge?

@troy0820
Copy link
Member Author

Let me check the integration tests, they are not showing up for some reason

@troy0820 troy0820 force-pushed the troy0820/update-deps branch from b60f704 to 77344ba Compare February 14, 2024 23:07
Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
@schristoff schristoff mentioned this pull request Feb 14, 2024
@schristoff
Copy link
Member

Do we need the comment for integ now? 😮‍💨 This workflow is so finnicky lately

[Invalid workflow file: .github/workflows/porter-integration-pr.yml#L14](https://github.com/getporter/porter/actions/runs/7908560634/workflow)
The workflow is not valid. .github/workflows/porter-integration-pr.yml (Line: 14, Col: 11): Input registry is required, but not provided while calling.

@schristoff
Copy link
Member

Thank you for doing this!

@schristoff schristoff merged commit 3f26d72 into getporter:main Mar 13, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants