Changed to golangci-lint and introduced LintChanges command #3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Gannon <19214156+dgannon991@users.noreply.github.com>
dgannon991
force-pushed
the
feat/3048/add-golangci-lint-command
branch
from
89d2c6e to
b6d5ee0
Compare
|
@schristoff - this will need the previous PR approving first, then a tweak from me, then I can publish it (if I've understood properly, shout if I've got that wrong!) As part of this, I changed the pipeline check to run LintChanges instead of just Lint, as the project currently has many lint issues, and it looks like it'll take a fair bit of work to fix them all. Happy if you'd rather I do them all in a one, but this approach seemed safer, as it'll force you to tidy up each file as it's worked on :) |
|
I'm going to guess |
Signed-off-by: David Gannon <19214156+dgannon991@users.noreply.github.com>
dgannon991
requested review from
schristoff,
sgettys,
bdegeeter and
troy0820
as code owners
Signed-off-by: David Gannon <19214156+dgannon991@users.noreply.github.com>
Signed-off-by: David Gannon <19214156+dgannon991@users.noreply.github.com>
Signed-off-by: David Gannon <19214156+dgannon991@users.noreply.github.com>
Signed-off-by: David Gannon <19214156+dgannon991@users.noreply.github.com>
schristoff
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Swapped to using golangci-lint as it's much more thorough. Also introduced a new command for LintChanges as there are LOTS of errors in the existing codebase.
What issue does it fix
Closes #3048
Notes for the reviewer
The prerequisite PR (getporter/magefiles#36) will need to be merged first. Then I can update this one to use the correct version of the magefile.
Checklist