Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mapped dependency outputs #3058

Merged
merged 8 commits into from
May 15, 2024

Conversation

kichristensen
Copy link
Contributor

What does this change

Implements support for dependency output mapping in Dependencies V2.
This is precursor to #2662 as it requires that dependency outputs can be mapped and templated. In this implementation only the "old" format is implemented, ${outputs.OUTPUT_NAME} is not supported yet, but will be implemented in a follow-up PR, where the documentation also would be updated.

What issue does it fix

Closes no issues but is a precursor to #2662

Notes for the reviewer

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

@kichristensen kichristensen marked this pull request as ready for review April 8, 2024 07:45
Copy link
Member

@schristoff schristoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate you taking action on this :)

pkg/runtime/runtime_manifest.go Outdated Show resolved Hide resolved
pkg/runtime/runtime_manifest_test.go Outdated Show resolved Hide resolved
pkg/runtime/runtime_manifest_test.go Show resolved Hide resolved
Signed-off-by: Kim Christensen <kimworking@gmail.com>
Signed-off-by: Kim Christensen <kimworking@gmail.com>
@kichristensen kichristensen requested a review from schristoff May 4, 2024 11:42
@schristoff schristoff merged commit 3d5654c into getporter:main May 15, 2024
15 checks passed
@kichristensen kichristensen deleted the mappedDependencyOutputs branch May 20, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants