Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable bundle reuse test #3072

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Reenable bundle reuse test #3072

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions tests/integration/build_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,10 @@ func TestRebuild(t *testing.T) {
// This is a regression test for a bug where the manifest would be considered out-of-date when nothing had changed
// caused by us using a go map when comparing the mixins used in the bundle, which has inconsistent sort order...

//todo: This test is flaky still and upsetting CI
// for i := 0; i < 5; i++ {
// _, output = test.RequirePorter("explain")
// tests.RequireOutputContains(t, output, "Bundle is up-to-date!", "expected the previous build to be reused")
// }
for i := 0; i < 10; i++ {
_, output = test.RequirePorter("explain")
tests.RequireOutputContains(t, output, "Bundle is up-to-date!", "expected the previous build to be reused")
}

bumpBundle()

Expand Down
Loading