Remove workflow_dispatch from test-porter-release action #3094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parameters cannot be used when triggered by anything other than workflow_dispatch. As this action is also triggered on PRs targeting the main branch, it cannot use parameters. Signed-off-by: Kim Christensen <kimworking@gmail.com>
kichristensen
requested review from
schristoff,
sgettys,
bdegeeter and
troy0820
as code owners
|
Now this is showing "test-porter-release" job on PRs, and I think we only want it on nightly or when there is a merge into main :/ |
|
@schristoff Good point, actually we might not want it at all, as the flow is also "tested" when producing the canary build on merge to main. That could be an argument for deleting the workflow all together. What to you think? |
|
I'm cool with deleting it :) |
The functionality is already covered by the canary release deployment Signed-off-by: Kim Christensen <kimworking@gmail.com>
|
@schristoff it is deleted instead |
schristoff
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Parameters cannot be used when triggered by anything other than workflow_dispatch. As this action is also triggered on PRs targeting the main branch, it cannot use parameters. An example of a failing action can be found here https://github.com/getporter/porter/actions/runs/8909019136.
Instead the parameters are no longer dynamic and the default values have been hardcoded.
UPDATE:
As the content of this workflow is already covered by the
porter/porter-canaryworkflow,test-porter-releaseis deleted instead.Checklist