-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct plugin logging #3185
Merged
schristoff
merged 6 commits into
getporter:main
from
kichristensen:fixPluginLogVerbosity
Aug 4, 2024
Merged
Correct plugin logging #3185
schristoff
merged 6 commits into
getporter:main
from
kichristensen:fixPluginLogVerbosity
Aug 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The log level is meant to be used only for log files. Signed-off-by: Kim Christensen <kimworking@gmail.com>
The constants used before was numbers, causing the writing to always fall back to writing as debug Signed-off-by: Kim Christensen <kimworking@gmail.com>
Signed-off-by: Kim Christensen <kimworking@gmail.com>
Signed-off-by: Kim Christensen <kimworking@gmail.com>
kichristensen
force-pushed
the
fixPluginLogVerbosity
branch
from
July 13, 2024 20:22
bb8f444
to
16c2c29
Compare
This was
linked to
issues
Jul 13, 2024
kichristensen
requested review from
schristoff,
sgettys,
bdegeeter and
troy0820
as code owners
July 13, 2024 21:11
@schristoff I think I got a mail about a comment on this PR, but cannot seem to find it again |
schristoff
approved these changes
Aug 4, 2024
jmcudd
pushed a commit
to jmcudd/porter
that referenced
this pull request
Aug 14, 2024
* The plugin logger should use verbosity level The log level is meant to be used only for log files. Signed-off-by: Kim Christensen <kimworking@gmail.com> * Correctly detect log level from plugin logs The constants used before was numbers, causing the writing to always fall back to writing as debug Signed-off-by: Kim Christensen <kimworking@gmail.com> * Correct the documentation Signed-off-by: Kim Christensen <kimworking@gmail.com> * Do not log information messages from the plugin infrastructure Signed-off-by: Kim Christensen <kimworking@gmail.com> --------- Signed-off-by: Kim Christensen <kimworking@gmail.com> Co-authored-by: schristoff <28318173+schristoff@users.noreply.github.com> Signed-off-by: John Cudd <jmcudd@gmail.com>
jmcudd
pushed a commit
to jmcudd/porter
that referenced
this pull request
Aug 19, 2024
* The plugin logger should use verbosity level The log level is meant to be used only for log files. Signed-off-by: Kim Christensen <kimworking@gmail.com> * Correctly detect log level from plugin logs The constants used before was numbers, causing the writing to always fall back to writing as debug Signed-off-by: Kim Christensen <kimworking@gmail.com> * Correct the documentation Signed-off-by: Kim Christensen <kimworking@gmail.com> * Do not log information messages from the plugin infrastructure Signed-off-by: Kim Christensen <kimworking@gmail.com> --------- Signed-off-by: Kim Christensen <kimworking@gmail.com> Co-authored-by: schristoff <28318173+schristoff@users.noreply.github.com> Signed-off-by: John Cudd <jmcudd@gmail.com>
Hi @kichristensen, I don't think I am seeing the fix.
Still need both in v1.1.1 above like in v1.1.0 below to get the debug detail. "--verbosity debug" alone is not enough.
|
@kurtschenk Based on the output I have to agree. I will take a look |
@kurtschenk I have found the error, and is working on a fix, fully covered by tests. Thank you very much for trying it out. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
--verbosity
flag #3189)What issue does it fix
Closes #3189 and closes #3188
Checklist