feat: Support signing bundles during copy #3204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it possible to sign bundles during copy between repositories. This is handle by creating a new signature, NOT by copying the potential existing signature. This is done for two reasons: 1. A signature might not be present on the source bundle 1. Repositories might use different digest algorithms or calculate the digest differently Signed-off-by: Kim Christensen <kimworking@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Make it possible to sign bundles during copy between repositories. This is handle by creating a new signature, NOT by copying the potential existing signature. This is done for two reasons:
What issue does it fix
Closes #3203
Notes for the reviewer
Test will be created after #3201 is merged, as the tests are refactored in that PR
Checklist