Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc for AKS integration #3206

Merged
merged 3 commits into from
Aug 24, 2024
Merged

Conversation

dejanu
Copy link
Contributor

@dejanu dejanu commented Aug 14, 2024

What does this change

Add documentation concerning AKS integration.

What issue does it fix

Closes #3173

Signed-off-by: dejanualex <dejanualexandru@gmail.com>
@schristoff
Copy link
Member

Please don't forget to add your name to the contributing.md file! Thank you so much :)

@dejanu
Copy link
Contributor Author

dejanu commented Aug 16, 2024

Please don't forget to add your name to the contributing.md file! Thank you so much :)

I added it the last time. Thx

Copy link
Contributor

@kichristensen kichristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the PR, looks really good. I have added two small comments

docs/content/docs/integrations/aks.md Outdated Show resolved Hide resolved
docs/content/docs/integrations/aks.md Outdated Show resolved Hide resolved
Signed-off-by: dejanualex <dejanualexandru@gmail.com>
@dejanu
Copy link
Contributor Author

dejanu commented Aug 22, 2024

@kichristensen, I've added Kubernetes mixin, just to illustrate the integration is working, hope it's ok. I've added a small video for demo purposes: https://youtu.be/lB1sjL55dZ0

@kichristensen
Copy link
Contributor

@dejanu Looks really good, thank you so much for the contribution

@kichristensen kichristensen merged commit d954afe into getporter:main Aug 24, 2024
30 checks passed
jmcudd pushed a commit to jmcudd/porter that referenced this pull request Sep 21, 2024
* add doc for AKS integration

Signed-off-by: dejanualex <dejanualexandru@gmail.com>

* remove merge action and outputs

Signed-off-by: dejanualex <dejanualexandru@gmail.com>

---------

Signed-off-by: dejanualex <dejanualexandru@gmail.com>
Co-authored-by: Kim Christensen <2461567+kichristensen@users.noreply.github.com>
Signed-off-by: John Cudd <jmcudd@gmail.com>
kichristensen added a commit that referenced this pull request Sep 24, 2024
* Simplified the bundle script

Signed-off-by: John Cudd <jmcudd@gmail.com>

* Added contributor

Signed-off-by: John Cudd <jmcudd@gmail.com>

* Updated docs

Signed-off-by: John Cudd <jmcudd@gmail.com>

* Removed trailing space

Signed-off-by: John Cudd <jmcudd@gmail.com>

* Added a note about mixins not being included

Signed-off-by: John Cudd <jmcudd@gmail.com>

* Tweaked the docs a bit

Signed-off-by: John Cudd <jmcudd@gmail.com>

* Added link at top

Signed-off-by: John Cudd <jmcudd@gmail.com>

* Add bundle script to release and netify redirects

Signed-off-by: John Cudd <jmcudd@gmail.com>

* Call host secrets plugin directly when resolving secrets (#3155)

We should not require all secret plugins to call the host secrets plugin
for non secret values. Instead we should call the host secrets plugin
directly.

Signed-off-by: Kim Christensen <kimworking@gmail.com>
Co-authored-by: schristoff <28318173+schristoff@users.noreply.github.com>
Signed-off-by: John Cudd <jmcudd@gmail.com>

* Add doc for AKS integration (#3206)

* add doc for AKS integration

Signed-off-by: dejanualex <dejanualexandru@gmail.com>

* remove merge action and outputs

Signed-off-by: dejanualex <dejanualexandru@gmail.com>

---------

Signed-off-by: dejanualex <dejanualexandru@gmail.com>
Co-authored-by: Kim Christensen <2461567+kichristensen@users.noreply.github.com>
Signed-off-by: John Cudd <jmcudd@gmail.com>

* Do not reference CNAB invocation images in documentation (#3200)

* Do not reference CNAB invocation images

As CNAB is an implementation detail as this point, we no longer want
to use the term 'invocation image'. Instead we should use the term
'bundle image'.
This PR ensures that the current references to 'invocation image' is
changed to 'bundle image'.

Signed-off-by: Kim Christensen <kimworking@gmail.com>

---------

Signed-off-by: Kim Christensen <kimworking@gmail.com>
Co-authored-by: schristoff <28318173+schristoff@users.noreply.github.com>
Signed-off-by: John Cudd <jmcudd@gmail.com>

* Bump actions/download-artifact from 3.0.1 to 4.1.7 in /.github/workflows in the github_actions group across 1 directory (#3217)

Bump actions/download-artifact

Bumps the github_actions group with 1 update in the /.github/workflows directory: [actions/download-artifact](https://github.com/actions/download-artifact).

Updates `actions/download-artifact` from 3.0.1 to 4.1.7
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3.0.1...v4.1.7)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  dependency-group: github_actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: John Cudd <jmcudd@gmail.com>

* fix: Update version of upload-artifact (#3219)

fix: Update upload-artifact action version

Signed-off-by: Kim Christensen <kimworking@gmail.com>
Signed-off-by: John Cudd <jmcudd@gmail.com>

* Correct the Cosign links that have stopped working (#3220)

fix: Correct the Cosign links that have stopped working

Signed-off-by: Kim Christensen <kimworking@gmail.com>
Co-authored-by: schristoff <28318173+schristoff@users.noreply.github.com>
Signed-off-by: John Cudd <jmcudd@gmail.com>

* Upgrade should not be allowed if installation is not installed (#3213)

fix: Upgrade should not be allowed if installation is not installed

Signed-off-by: Kim Christensen <kimworking@gmail.com>
Signed-off-by: John Cudd <jmcudd@gmail.com>

* Updated documentation to explain mongo

Also removed echo from the extraction instructions.

Signed-off-by: John Cudd <jmcudd@gmail.com>

---------

Signed-off-by: John Cudd <jmcudd@gmail.com>
Signed-off-by: Kim Christensen <kimworking@gmail.com>
Signed-off-by: dejanualex <dejanualexandru@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Kim Christensen <2461567+kichristensen@users.noreply.github.com>
Co-authored-by: schristoff <28318173+schristoff@users.noreply.github.com>
Co-authored-by: dejanualex <dejanualexandru@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation on connecting to AKS
3 participants