-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offline Porter Installation #3210
Conversation
7f5cbc0
to
02c098f
Compare
@kichristensen I took your feedback, in PR #3205, about the added complexity in the install script and came up with an alternative that keeps things fairly simple. One thing to note about this is it doesn't solve installation of mixins, I'm not sure how that would be solved. |
@jmcudd Thanks for the PR, I will do some testing locally tomorrow and get back to you. But overall I like it |
Could you update the documentation with a note, saying the mixins aren't handled by the script? Just to make it clear for users that mixins aren't currently handled |
I also think it would make a lot if sense to add the script to the release just like we do with |
585b601
to
58ba090
Compare
Here is what I've addressed in my latest changes:
|
This looks great, aside from Kim's documentation request. Thank you :) |
I'll try to find some time this week to make the requested additions to the documentation. |
Signed-off-by: John Cudd <jmcudd@gmail.com>
Signed-off-by: John Cudd <jmcudd@gmail.com>
Signed-off-by: John Cudd <jmcudd@gmail.com>
Signed-off-by: John Cudd <jmcudd@gmail.com>
Signed-off-by: John Cudd <jmcudd@gmail.com>
Signed-off-by: John Cudd <jmcudd@gmail.com>
Signed-off-by: John Cudd <jmcudd@gmail.com>
Signed-off-by: John Cudd <jmcudd@gmail.com>
) We should not require all secret plugins to call the host secrets plugin for non secret values. Instead we should call the host secrets plugin directly. Signed-off-by: Kim Christensen <kimworking@gmail.com> Co-authored-by: schristoff <28318173+schristoff@users.noreply.github.com> Signed-off-by: John Cudd <jmcudd@gmail.com>
* add doc for AKS integration Signed-off-by: dejanualex <dejanualexandru@gmail.com> * remove merge action and outputs Signed-off-by: dejanualex <dejanualexandru@gmail.com> --------- Signed-off-by: dejanualex <dejanualexandru@gmail.com> Co-authored-by: Kim Christensen <2461567+kichristensen@users.noreply.github.com> Signed-off-by: John Cudd <jmcudd@gmail.com>
) * Do not reference CNAB invocation images As CNAB is an implementation detail as this point, we no longer want to use the term 'invocation image'. Instead we should use the term 'bundle image'. This PR ensures that the current references to 'invocation image' is changed to 'bundle image'. Signed-off-by: Kim Christensen <kimworking@gmail.com> --------- Signed-off-by: Kim Christensen <kimworking@gmail.com> Co-authored-by: schristoff <28318173+schristoff@users.noreply.github.com> Signed-off-by: John Cudd <jmcudd@gmail.com>
…ows in the github_actions group across 1 directory (getporter#3217) Bump actions/download-artifact Bumps the github_actions group with 1 update in the /.github/workflows directory: [actions/download-artifact](https://github.com/actions/download-artifact). Updates `actions/download-artifact` from 3.0.1 to 4.1.7 - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v3.0.1...v4.1.7) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production dependency-group: github_actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: John Cudd <jmcudd@gmail.com>
fix: Update upload-artifact action version Signed-off-by: Kim Christensen <kimworking@gmail.com> Signed-off-by: John Cudd <jmcudd@gmail.com>
fix: Correct the Cosign links that have stopped working Signed-off-by: Kim Christensen <kimworking@gmail.com> Co-authored-by: schristoff <28318173+schristoff@users.noreply.github.com> Signed-off-by: John Cudd <jmcudd@gmail.com>
…rter#3213) fix: Upgrade should not be allowed if installation is not installed Signed-off-by: Kim Christensen <kimworking@gmail.com> Signed-off-by: John Cudd <jmcudd@gmail.com>
Also removed echo from the extraction instructions. Signed-off-by: John Cudd <jmcudd@gmail.com>
9361649
to
1079b5a
Compare
What does this change
The new
bundle-linux.sh
script automates the creation of a tarball containing all the necessary artifacts for installing the Porter CLI, including the MongoDB Docker image and the Porter installation files. It pulls a specific version of the MongoDB image and packages all the downloaded assets into a compressed tarball, providing clear instructions for extracting the bundle and executing the installation script. This makes it easy for users to set up Porter in air-gapped environments.The
install-linux.sh
script has been updated to local or remote binaries, to facilitate an offline installation. This is accomplished by setting thePORTER_BINARY_URL
to afile://<absolute-path-to-linux-binary>
instead of the Porter CDN.What issue does it fix
Closes #3198
Notes for the reviewer
This PR directly addresses feedback about complexity of the installation script in PR #3205
The
bundle-linux.sh
script pulls the latest version of theinstall-linux.sh
from the CDN, so when testing you will need to replace the downloadedinstall-linux.sh
file with the one from this branch. Use the following command.Checklist