Retag referenced images when they are relocated #3231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kichristensen
changed the title
During relocation of referenced images, the images will no longer loose their tag and name. Signed-off-by: Kim Christensen <kimworking@gmail.com>
kichristensen
force-pushed
the
retagRelocatedImages
branch
from
f535765 to
01ffe44
Compare
Signed-off-by: Kim Christensen <kimworking@gmail.com>
kichristensen
requested review from
schristoff,
sgettys,
bdegeeter and
troy0820
as code owners
Signed-off-by: Kim Christensen <kimworking@gmail.com>
schristoff
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
During relocation of referenced images, the images will loose their tag, and only be able through the
<BUNDLE_NAME>@<DIGEST>.This makes it hard to use the image from outside the bundle. This is also a prerequisite for #2670.
What issue does it fix
Closes #2711
Notes for the reviewer
The bundle stamp is updated to contain information on if we are preserving tags, the reason is that change the setting requires a rebuild of the bundle.
Checklist