Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass in context to cnab-go Run() #3253

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dgannon991
Copy link
Member

What does this change

Passes in our context to the cnab-go runtime, so that if our context is cancelled, they drop the container.

What issue does it fix

Closes #2234

Notes for the reviewer

As it stands this is still draft, it contains a go.mod overwrite to a branch of cnab-go, I'm just putting it up to help test my changes to cnab-go

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Signed-off-by: David Gannon <19214156+dgannon991@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canceling porter should cancel the invocation image
1 participant