Write warning on missing version v to stderr
#3263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbergnehr
requested review from
schristoff,
sgettys,
bdegeeter,
troy0820 and
kichristensen
as code owners
lbergnehr
changed the title
v to stderrv to stderr
Writing it to stdout can cause structured results, such as when using `--format json` to become invalid. Signed-off-by: Leo Bergnéhr <leo@bergnehr.se>
schristoff
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
When getting a bundle through a reference, e.g.
porter explain --reference..., and the version of the bundle does not contain av, write warning on missingvto stderr. Writing it to stdout can cause structured results, such as when using--format jsonto become invalid.What issue does it fix
Closes #3262
Checklist