fix falsey comparison to determine whether a dashboard is archived. closes #6560 #6561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6561 +/- ##
=======================================
Coverage 61.89% 61.89%
=======================================
Files 158 158
Lines 12968 12968
Branches 1772 1772
=======================================
Hits 8027 8027
Misses 4665 4665
Partials 276 276
|
|
Works on my local! |
|
Cool, sounds like good investigation. 😄 |
justinclift
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
When
blackupdated our code, it removed a falsey comparison that was using==, but that was an overloaded operator from SQLAlchemy. Instead of using theisoperator, which cannot be overloaded, we need to use the.is_()method to compare properly and achieve the same behavior.How is this tested?
Related Tickets & Documents
Closes #6560
Mobile & Desktop Screenshots/Recordings (if there are UI changes)