Default to not allow HTML content in tables #7064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezraodio1
force-pushed
the
change-allow-html-default
branch
from
57f68ca to
b89fe21
Compare
|
Let's consider this change after |
eradman
force-pushed
the
change-allow-html-default
branch
from
b89fe21 to
7ceca00
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7064 +/- ##
=======================================
Coverage 64.01% 64.01%
=======================================
Files 163 163
Lines 13410 13410
Branches 1905 1905
=======================================
Hits 8585 8585
Misses 4490 4490
Partials 335 335 |
|
Rebased this branch and tested locally. New goal: merge after |
|
We really need to drop the leading zeros in our tag names too. |
|
Four 👍 reactions to t his change. @justinclift okay to merge? |
eradman
force-pushed
the
change-allow-html-default
branch
from
7ceca00 to
b80c148
Compare
|
LGTM! At my company, this value default is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Change the default for each column in a table to not allow HTML. This addresses a potential security issue.
How is this tested?
Verified that the default behavior changes when a table is created.
Related Tickets & Documents
#6615
Mobile & Desktop Screenshots/Recordings (if there are UI changes)