Fixes #7272: Error in rehash DB migration with Elasticsearch queries #7292
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eradman |
eradman
approved these changes
Jan 22, 2025
|
For this I think we can skip the Codecov Report. Not sure how, but I'll try removing the report from this thread |
eradman
force-pushed
the
fix-elasticsearch-migration
branch
from
e20fac0 to
e4b13a2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7292 +/- ##
=======================================
Coverage 64.01% 64.01%
=======================================
Files 163 163
Lines 13410 13410
Branches 1905 1905
=======================================
Hits 8585 8585
Misses 4490 4490
Partials 335 335
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
When migrating from Redash 10.1.0 to 25.1.0, the initialization of the Elasticsearch query runner is triggered, causing an error to be thrown. In addition to the measures implemented in #7258, the current fix ensures that the migration proceeds successfully.
How is this tested?
The same issue as #7272 occurred in the current environment. After applying this fix, running
docker-compose run --rm server manage db upgradecompleted the migration successfully, and it was confirmed that Elasticsearch queries can now be executed.Related Tickets & Documents