Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: org-wide secret scanning #129

Merged
merged 1 commit into from
May 23, 2024
Merged

security: org-wide secret scanning #129

merged 1 commit into from
May 23, 2024

Conversation

mdtro
Copy link
Member

@mdtro mdtro commented May 21, 2024

Sentry uses GH's Secret Scanning on our public repositories, including their push protection to prevent secret leaks.

However, this does not cover private repositories without an expensive GHAS license. With this org-wide workflow, this will ensure secret scanning occurs on pull requests whether they're in a private or public repository.

This workflow does not pull the full commit history but just the current default branch + 2 commit to make sure scanning stays speedy. As a result, this won't detect secrets already committed to private repos, but we're working through any of those in a separate work stream.

@mdtro mdtro marked this pull request as ready for review May 23, 2024 21:44
@mdtro mdtro requested a review from a team May 23, 2024 21:44
Copy link
Contributor

@geoffg-sentry geoffg-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A+ and <3 codesign verify

@mdtro mdtro merged commit 01c9c63 into main May 23, 2024
1 check passed
@mdtro mdtro deleted the mdtro/trufflehog branch May 23, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants