feat: upgrade cli version #169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 25, 2023 11:37
added 13 commits
October 25, 2023 12:26
mdtro
reviewed
Oct 26, 2023
Comment on lines
+8
to
+13
| Sentry.init({ | ||
| dsn: 'https://156a0eddcf407521a39833be862fc0e6@o1.ingest.sentry.io/4506112609943552', | ||
| // Performance Monitoring | ||
| tracesSampleRate: 1.0, | ||
| }); | ||
|
|
There was a problem hiding this comment.
Can we do this? A lot of repos use this action, wouldn't this collect data?
https://github.com/getsentry/action-release/network/dependents
Comment on lines
+29
to
+34
| # download a copy of sentry-cli | ||
| # TODO: Figure out why we can't use the version that is in node modules | ||
| RUN apk update && apk add curl | ||
| RUN curl -sL https://sentry.io/get-cli/ | SENTRY_CLI_VERSION="2.21.2" sh | ||
| RUN chmod +x /usr/local/bin/sentry-cli | ||
| ENV SENTRY_BINARY_PATH=/usr/local/bin/sentry-cli |
There was a problem hiding this comment.
this downloads the cli twice -- once in npm land and once here -- probably not what you want? maybe you mean to execute node_moduldes/.bin/sentry-cli ... ?
There was a problem hiding this comment.
@asottile-sentry I tried this but seems like that doesn't work. I guess I'll keep trying.
|
there's a lot going on in this PR -- can you split it into several different patches to minimize risk? probably separate out:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of the CLI is quite out of date, this PR upgrades it to the latest which is 2.21.2.