feat(profiling) use continuous profiler instead of the span/txn based one #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasBa
force-pushed
the
jb/chartcuterie/continuous-profiler
branch
from
66e46bf
to
f4f5919
Compare
AbhiPrasad
approved these changes
Jun 18, 2024
|
|
||
| if(profilingIntegration) { | ||
| // @ts-expect-error this is purposefuly not exposed by the SDK for now | ||
| profilingIntegration._profiler.start(); |
There was a problem hiding this comment.
Oh interesting, this doesn't require a profilesSampleRate?
There was a problem hiding this comment.
No, we actually rely on it not being set. It's a bit weird from the API pov, but we dont want to apply the sampling rate per chunk.
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
JonasBa
added a commit
that referenced
this pull request
Jun 19, 2024
… one (#161) * feat(profiling) use continuous profiler instead * Update src/instrument.ts Co-authored-by: Abhijeet Prasad <aprasad@sentry.io> * Update src/instrument.ts Co-authored-by: Abhijeet Prasad <aprasad@sentry.io> --------- Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to start ingesting some profiles from a production env using the new continuous profiler