Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run release builds on PRs #67

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Run release builds on PRs #67

merged 2 commits into from
Sep 18, 2024

Conversation

armenzg
Copy link
Member

@armenzg armenzg commented Sep 17, 2024 •
edited
Loading

This will help to determine that the build process has not regressed in pull requests.

Notice that the upload step is skipped:
image

@armenzg
Run release builds on PRs
c4857e0 
We will not upload the wheels, however, this will help to determine that the build process has not regressed.
@armenzg armenzg self-assigned this Sep 17, 2024
asottile-sentry
asottile-sentry reviewed Sep 17, 2024
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
Swatinem
Swatinem reviewed Sep 18, 2024
View reviewed changes
Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I somewhat agree that it might be good to actually test this workflow regularly.
On the other hand though, I’m a bit hesitant as this is just burning CI time. Though I don’t think we pay for that out of pocket really.

@armenzg armenzg merged commit e44ea09 into master Sep 18, 2024
18 checks passed
@armenzg armenzg deleted the run_release_build_on_prs branch September 18, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swatinem Swatinem Swatinem approved these changes

@loewenheim loewenheim Awaiting requested review from loewenheim

@asottile-sentry asottile-sentry Awaiting requested review from asottile-sentry

Assignees

@armenzg armenzg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@armenzg @Swatinem @asottile-sentry