Allow PDB to impl Send.
#148
Conversation
|
@jan-auer Could you take a look at this? It's needed for mstange/pdb-addr2line#63 |
|
Bump @jan-auer, any chance of this getting in? |
| where | ||
| S: Send, |
There was a problem hiding this comment.
I'm worried that not all consumers can provide a Send object as the parameter to PDB::open.
It would be nice if we could find a way to make PDB send whenever S is Send.
There was a problem hiding this comment.
I think I've seen ways of doing this with trait objects, though (if I am remembering correctly) they are understandably hacky/cumbersome. It would be easier if this didn't store a dyn Msf. There's only one implementation of that, so we could avoid the trait object fairly easily...
There was a problem hiding this comment.
TBH as of these changes, Source must be able to provide Send + Sync SourceViews, so I'd be surprised if Source was not at least Send too.
This allows
PDBto be used across await points in async blocks. It also enablesSyncaccess by e.g. wrapping with aMutex.This results in just one API-breaking change, where the
Source::viewtrait method must now return a boxed trait object which isSend + Sync. If this breakage is unacceptable, maybe these changes could be behind a feature?