Skip to content

Commit

Permalink
fix(benchmarks): Aggregator benchmark naming and throughput (#3850)
Browse files Browse the repository at this point in the history
- the benchmarks shouldn't share a group, they are different benchmarks
- the flush benchmark does not have a throughput, it's a single
operation
  • Loading branch information
Dav1dde authored Jul 23, 2024
1 parent 78050d3 commit 1f508d4
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions relay-metrics/benches/benches.rs
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ fn bench_insert_and_flush(c: &mut Criterion) {

for (input_name, input) in &inputs {
{
let mut group = c.benchmark_group(*input_name);
let mut group = c.benchmark_group("insert");
group.throughput(criterion::Throughput::Elements(input.num_buckets as u64));
group.bench_with_input(
BenchmarkId::new("bench_insert_metrics", input_name),
Expand Down Expand Up @@ -211,8 +211,7 @@ fn bench_insert_and_flush(c: &mut Criterion) {
);
}

let mut group = c.benchmark_group(*input_name);
group.throughput(criterion::Throughput::Elements(input.num_buckets as u64));
let mut group = c.benchmark_group("flush");
group.bench_with_input(
BenchmarkId::new("bench_flush_metrics", input_name),
&input,
Expand Down

0 comments on commit 1f508d4

Please sign in to comment.