Skip to content

Commit

Permalink
feat(app-start): Add app_start_type to duration (#3066)
Browse files Browse the repository at this point in the history
This field is required for querying on the spans indexed dataset for a
table that surfaces segment spans by start type.
  • Loading branch information
narsaynorath authored Feb 7, 2024
1 parent 5fd3969 commit 26205c0
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
- Add `raw_domain` tag to indexed spans. ([#2975](https://github.com/getsentry/relay/pull/2975))
- Obtain `span.domain` field from the span data's `url.scheme` and `server.address` properties when applicable. ([#2975](https://github.com/getsentry/relay/pull/2975))
- Do not truncate simplified SQL expressions. ([#3003](https://github.com/getsentry/relay/pull/3003))
- Add `app_start_type` as self time tag for app start spans. ([#3027](https://github.com/getsentry/relay/pull/3027))
- Add `app_start_type` as a tag for self time and duration for app start spans. ([#3027](https://github.com/getsentry/relay/pull/3027)), ([#3066](https://github.com/getsentry/relay/pull/3066))

**Internal**:

Expand Down
3 changes: 3 additions & 0 deletions relay-dynamic-config/src/defaults.rs
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,9 @@ fn span_metrics() -> impl IntoIterator<Item = MetricSpec> {
Tag::with_key("environment")
.from_field("span.sentry_tags.environment")
.always(), // already guarded by condition on metric
Tag::with_key("app_start_type")
.from_field("span.sentry_tags.app_start_type")
.always(), // already guarded by condition on metric
],
},
MetricSpec {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -497,6 +497,7 @@ expression: "(&event.value().unwrap().spans, metrics)"
],
),
tags: {
"app_start_type": "warm",
"device.class": "1",
"os.name": "iOS",
"release": "1.2.3",
Expand Down

0 comments on commit 26205c0

Please sign in to comment.