Skip to content

Commit

Permalink
fix: Lint
Browse files Browse the repository at this point in the history
  • Loading branch information
jan-auer committed Aug 27, 2024
1 parent 8ef64a7 commit 659b92c
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 13 deletions.
13 changes: 1 addition & 12 deletions relay-server/src/services/metrics/aggregator.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ use relay_metrics::aggregator::AggregateMetricsError;
use relay_metrics::{aggregator, Bucket, UnixTimestamp};
use relay_system::{Controller, FromMessage, Interface, NoResponse, Recipient, Service, Shutdown};

use crate::statsd::{RelayCounters, RelayHistograms, RelayTimers};
use crate::statsd::{RelayCounters, RelayHistograms};

/// Aggregator for metric buckets.
///
Expand All @@ -31,17 +31,6 @@ pub enum Aggregator {
BucketCountInquiry(BucketCountInquiry, relay_system::Sender<usize>),
}

impl Aggregator {
/// Returns the name of the message variant.
pub fn variant(&self) -> &'static str {
match self {
Aggregator::MergeBuckets(_) => "MergeBuckets",
#[cfg(test)]
Aggregator::BucketCountInquiry(_, _) => "BucketCountInquiry",
}
}
}

impl Interface for Aggregator {}

impl FromMessage<MergeBuckets> for Aggregator {
Expand Down
1 change: 0 additions & 1 deletion relay-server/src/services/metrics/router.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ use relay_system::{Addr, NoResponse, Recipient, Service};
use crate::services::metrics::{
Aggregator, AggregatorHandle, AggregatorService, FlushBuckets, MergeBuckets,
};
use crate::statsd::RelayTimers;
use crate::utils;

/// Service that routes metrics & metric buckets to the appropriate aggregator.
Expand Down
3 changes: 3 additions & 0 deletions relay-server/src/statsd.rs
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,7 @@ pub enum RelayTimers {
/// This metric is tagged with:
///
/// - `message`: The type of message that was processed.
#[allow(dead_code)] // TODO: Temporarily disabled for a performance measurement.
ProcessMessageDuration,
/// Timing in milliseconds for handling a project cache message.
///
Expand Down Expand Up @@ -503,11 +504,13 @@ pub enum RelayTimers {
///
/// This metric is tagged with:
/// - `message`: The type of message that was processed.
#[allow(dead_code)] // TODO: Temporarily disabled for a performance measurement.
AggregatorServiceDuration,
/// Timing in milliseconds for processing a message in the metric router service.
///
/// This metric is tagged with:
/// - `message`: The type of message that was processed.
#[allow(dead_code)] // TODO: Temporarily disabled for a performance measurement.
MetricRouterServiceDuration,
/// Timing in milliseconds for processing a message in the metric store service.
///
Expand Down

0 comments on commit 659b92c

Please sign in to comment.