ref(statsd): Skip counter updates if the value is zero (#3747)

No need to update a counter if the value is zero.
getsentry · Jun 19, 2024 · 7043987 · 7043987
1 parent cf3e3b1
commit 7043987
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 15 deletions.
diff --git a/relay-server/src/services/processor/event.rs b/relay-server/src/services/processor/event.rs
@@ -431,7 +431,7 @@ pub fn emit_feedback_metrics(envelope: &Envelope) {
             _ => (),
         }
     }
-    if has_feedback && num_attachments > 0 {
+    if has_feedback {
         metric!(counter(RelayCounters::FeedbackAttachments) += num_attachments);
     }
 }

diff --git a/relay-statsd/src/lib.rs b/relay-statsd/src/lib.rs
@@ -529,24 +529,34 @@ pub trait GaugeMetric {
 macro_rules! metric {
     // counter increment
     (counter($id:expr) += $value:expr $(, $k:ident = $v:expr)* $(,)?) => {
-        $crate::with_client(|client| {
-            use $crate::_pred::*;
-            client.send_metric(
-                client.count_with_tags(&$crate::CounterMetric::name(&$id), $value)
-                $(.with_tag(stringify!($k), $v))*
-            )
-        })
+        match $value {
+            value if value != 0 => {
+                $crate::with_client(|client| {
+                    use $crate::_pred::*;
+                    client.send_metric(
+                        client.count_with_tags(&$crate::CounterMetric::name(&$id), value)
+                        $(.with_tag(stringify!($k), $v))*
+                    )
+                })
+            },
+            _ => {},
+        };
     };
 
     // counter decrement
     (counter($id:expr) -= $value:expr $(, $k:ident = $v:expr)* $(,)?) => {
-        $crate::with_client(|client| {
-            use $crate::_pred::*;
-            client.send_metric(
-                client.count_with_tags(&$crate::CounterMetric::name(&$id), -$value)
-                    $(.with_tag(stringify!($k), $v))*
-            )
-        })
+        match $value {
+            value if value != 0 => {
+                $crate::with_client(|client| {
+                    use $crate::_pred::*;
+                    client.send_metric(
+                        client.count_with_tags(&$crate::CounterMetric::name(&$id), -value)
+                            $(.with_tag(stringify!($k), $v))*
+                    )
+                })
+            },
+            _ => {},
+        };
     };
 
     // gauge set