Skip to content

Commit

Permalink
feat(metric-stats): Emit negative outcome for denied metrics (#3508)
Browse files Browse the repository at this point in the history
  • Loading branch information
iambriccardo committed May 6, 2024
1 parent 24037f4 commit c64b44d
Show file tree
Hide file tree
Showing 5 changed files with 314 additions and 115 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- Add metrics extraction config to global config. ([#3490](https://github.com/getsentry/relay/pull/3490), [#3504](https://github.com/getsentry/relay/pull/3504))
- Extract `cache.item_size` from measurements instead of data. ([#3510](https://github.com/getsentry/relay/pull/3510))
- Collect `enviornment` tag as part of exclusive_time_light for cache spans. ([#3510](https://github.com/getsentry/relay/pull/3510))
- Emit negative outcomes for denied metrics. ([#3508](https://github.com/getsentry/relay/pull/3508))

## 24.4.2

Expand Down
4 changes: 4 additions & 0 deletions relay-filter/src/common.rs
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ pub enum FilterStatKey {
/// Filtered due to the fact that it was a call to a filtered transaction
FilteredTransactions,

/// Filtered due to name being denied.
DeniedName,

/// Filtered due to a generic filter.
GenericFilter(String),
}
Expand Down Expand Up @@ -65,6 +68,7 @@ impl FilterStatKey {
FilterStatKey::WebCrawlers => "web-crawlers",
FilterStatKey::InvalidCsp => "invalid-csp",
FilterStatKey::FilteredTransactions => "filtered-transaction",
FilterStatKey::DeniedName => "denied-name",
FilterStatKey::GenericFilter(filter_identifier) => {
return Cow::Owned(filter_identifier);
}
Expand Down
Loading

0 comments on commit c64b44d

Please sign in to comment.