Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(arm): Adds support for cross compilation and publishes Relay ARM docker images #3272

Merged
merged 75 commits into from
Apr 29, 2024

Conversation

Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented Mar 15, 2024

Updates the build/ci to support building multi arch docker images.

  • Removes the now-unused docker images and build scripts, they are no longer used and we don't want to maintain them, they will eventually break.
  • Uses regctl to transfer multi arch images directly between registries
  • Fixes relay-debug.zip and relay.src.zip inconsistency

Future improvements:

  • Add aarch64-apple-darwin to the matrix build
  • Release aarch64 binaries on release builds
  • Sign images (?)

I tested all modified workflows (like binary) and they still work:

As a goodie, the docker image pipeline should be a bit faster now when re-running (~ 5 minutes), cutting down on that total CI time :)

Closes: #1305

@Dav1dde Dav1dde force-pushed the one-armed-bandit branch 2 times, most recently from e2a90c7 to e205d27 Compare March 15, 2024 09:08
@Dav1dde Dav1dde force-pushed the one-armed-bandit branch 7 times, most recently from 451a2eb to 02ef2f3 Compare March 15, 2024 10:43
@Dav1dde Dav1dde changed the title . ci(arm): Adds support for cross compilation and publishes Relay ARM docker images Apr 19, 2024
@Dav1dde Dav1dde marked this pull request as ready for review April 19, 2024 12:48
@Dav1dde Dav1dde requested a review from a team as a code owner April 19, 2024 12:48
Copy link
Contributor

@olksdr olksdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since in the description stays you tested the release workflows I have no other questions

great! :shipit:

Once thing is left - try to deploy newly built image after this PR is merged and see that everything is still functioning as expected 😄

steps:
- uses: actions/checkout@v4

- uses: docker/setup-qemu-action@v3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so it does use qemu for something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure, I think buildx needs it to build the image, but the binary is compiled outside of the docker image, hence why it's almost instant.


steps:
- name: Install cosign
uses: sigstore/cosign-installer@v3.5.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we already sign images?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just so the regclient action checks the signature of the regclient binary, they had that in their readme and thought it was a good idea.

@Dav1dde Dav1dde force-pushed the one-armed-bandit branch 4 times, most recently from fea4002 to 91891dc Compare April 19, 2024 15:09
@Dav1dde Dav1dde merged commit 8c75086 into master Apr 29, 2024
26 checks passed
@Dav1dde Dav1dde deleted the one-armed-bandit branch April 29, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arm64 support for Docker images
2 participants