-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(arm): Adds support for cross compilation and publishes Relay ARM docker images #3272
Conversation
e2a90c7
to
e205d27
Compare
e205d27
to
dc924ee
Compare
This reverts commit f458632.
451a2eb
to
02ef2f3
Compare
02ef2f3
to
4e044f3
Compare
830e07b
to
ab1cd42
Compare
ab1cd42
to
485f523
Compare
7d52ba6
to
4500d51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since in the description stays you tested the release workflows I have no other questions
great!
Once thing is left - try to deploy newly built image after this PR is merged and see that everything is still functioning as expected 😄
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- uses: docker/setup-qemu-action@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so it does use qemu for something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% sure, I think buildx needs it to build the image, but the binary is compiled outside of the docker image, hence why it's almost instant.
|
||
steps: | ||
- name: Install cosign | ||
uses: sigstore/cosign-installer@v3.5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we already sign images?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just so the regclient
action checks the signature of the regclient binary, they had that in their readme and thought it was a good idea.
fea4002
to
91891dc
Compare
91891dc
to
11ab0cc
Compare
Updates the build/ci to support building multi arch docker images.
regctl
to transfer multi arch images directly between registriesrelay-debug.zip
andrelay.src.zip
inconsistencyFuture improvements:
aarch64-apple-darwin
to the matrix buildI tested all modified workflows (like binary) and they still work:
As a goodie, the docker image pipeline should be a bit faster now when re-running (~ 5 minutes), cutting down on that total CI time :)
Closes: #1305