Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(binary): Build binary on ubuntu 20.04 for lower glibc requirement #3586

Merged
merged 1 commit into from
May 14, 2024

Conversation

Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented May 13, 2024

Build release binaries in ubuntu 20.04 this lowers the glibc requirements of the resulting binaries. This was unintentionally bumped when adding the ARM builds and broke the binary for older glibc versions in the 24.4.2 release.

We build the docker image binaries in a docker container with an even lower glibc requirement, so with #3497 we should just use the binaries built with cross for the release.

#skip-changelog

@Dav1dde Dav1dde requested a review from a team as a code owner May 13, 2024 16:11
@Dav1dde Dav1dde self-assigned this May 13, 2024
@Dav1dde Dav1dde merged commit 5cbd814 into master May 14, 2024
24 checks passed
@Dav1dde Dav1dde deleted the dav1d/glibc-release branch May 14, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants