Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: use macos arm builders to speed up library build #3611

Merged
merged 1 commit into from
May 16, 2024
Merged

ref: use macos arm builders to speed up library build #3611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build_binary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:

macos:
name: macOS
runs-on: macos-11
runs-on: macos-14

steps:
- uses: actions/checkout@v4
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/build_library.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,12 @@ jobs:
matrix:
include:
- target: x86_64-apple-darwin
py-platform: macosx-10_15_x86_64
py-platform: macosx-14_0_x86_64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we require >= macOS 14 now for all of sentry development? If not, I'd at least keep the intel build where it was.

Technically, there shouldn't be any problems, I noticed that even built on newer versions binaries require a lower version number of the system libraries, but still...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the value here ~generally needs to match the platform it is built from -- it's already wrong on master :)

but yes we already require macos>=14

- target: aarch64-apple-darwin
py-platform: macosx-11_0_arm64
py-platform: macosx-14_0_arm64

name: Python macOS ${{ matrix.py-platform }}
runs-on: macos-11
runs-on: macos-14

steps:
- uses: actions/checkout@v4
Expand Down
4 changes: 2 additions & 2 deletions py/.craft.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ targets:
cacheControl: "public, max-age=2592000"

requireNames:
- /^sentry_relay-.*-py2\.py3-none-macosx_10_15_x86_64.whl$/
- /^sentry_relay-.*-py2\.py3-none-macosx_11_0_arm64.whl$/
- /^sentry_relay-.*-py2\.py3-none-macosx_14_0_x86_64.whl$/
- /^sentry_relay-.*-py2\.py3-none-macosx_14_0_arm64.whl$/
- /^sentry_relay-.*-py2\.py3-none-.*manylinux2014_x86_64.*\.whl$/
- /^sentry_relay-.*-py2\.py3-none-.*manylinux2014_aarch64.*\.whl$/
- /^sentry-relay-.*\.zip$/
1 change: 1 addition & 0 deletions py/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Unreleased

- Remove publishing of x86 wheels. [#3596](https://github.com/getsentry/relay/pull/3596)
- Require minimum macos 14.x for wheels [#3611](https://github.com/getsentry/relay/pull/3611)

## 0.8.64

Expand Down
Loading