Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(ci): Enable self hosted checks for forks #3678

Closed
wants to merge 4 commits into from

Conversation

dav1d
Copy link

@dav1d dav1d commented Jun 3, 2024

#skip-changelog

@dav1d dav1d requested a review from a team as a code owner June 3, 2024 09:07
@Dav1dde Dav1dde changed the title DONT MERGE TEST ONLY ci(ci): Enable self hosted checks for forks Jun 3, 2024
@Dav1dde Dav1dde self-assigned this Jun 3, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Build and push to ghcr.io in build-docker job is being skipped due to being a fork, We'll need to change this too if we 'd like to enable self-hosted checks for forks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The job now imports the image from a build artifact if access to ghcr is not available.

@Dav1dde
Copy link
Member

Dav1dde commented Jun 3, 2024

Mh still doesn't work because the install script also tries to pull https://github.com/getsentry/self-hosted/blob/c40b1530d104e9481d172e06dc6810bea0795d5c/install/ensure-relay-credentials.sh#L27

@Dav1dde
Copy link
Member

Dav1dde commented Jun 3, 2024

We don't want to update the self hosted install scripts to accommodate for this.

@Dav1dde Dav1dde closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants