feat(normalization): bypass host scrubbing via allow list #3813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
reviewed
Jul 12, 2024
Co-authored-by: Joris Bayer <jjbayer@gmail.com>
jjbayer
reviewed
Jul 15, 2024
| /// ``` | ||
| pub fn scrub_host(host: Host<&str>) -> Cow<'_, str> { | ||
| pub fn scrub_host<'a>(host: Host<&'a str>, allow_list: &'a [String]) -> Cow<'a, str> { | ||
| if allow_list.contains(&host.to_string()) { |
There was a problem hiding this comment.
scrub_ipv4/6 below still have a hard-coded check to allow localhost. Should we put localhost as the default on sentry side instead, and remove the localhost special-case from the relay code?
|
@Dav1dde @jjbayer Do you guys know why this happened? Do I need to setup anything other than running |
I haven't encountered this error before. |
|
@aldy505 any luck with your setup? If not, I'm happy to trigger your test runs manually. |
This was referenced Aug 4, 2024
jjbayer
added a commit
to getsentry/sentry
that referenced
this pull request
Aug 5, 2024
…74195) Complementary relay config for getsentry/relay#3813, based on the discussion on getsentry/relay#3572 ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. --------- Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
TheDevMinerTV
added a commit
to TheDevMinerTV/relay
that referenced
this pull request
Aug 16, 2024
TheDevMinerTV
added a commit
to TheDevMinerTV/relay
that referenced
this pull request
Aug 16, 2024
Fixes compile error in getsentry#3813
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on #3572. If this is okay, then someone would need to open a PR on sentry for additional relay config.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.