ref(store): Multithread the store using a rayon pool #3837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
commented
Jul 19, 2024
| @@ -59,8 +60,10 @@ impl Validator { | |||
| .map(drop) | |||
| } | |||
|
|
|||
| fn get_schema(&mut self, topic: KafkaTopic) -> Result<Option<&SentrySchema>, SchemaError> { | |||
| Ok(match self.schemas.entry(topic) { | |||
| fn get_schema(&self, topic: KafkaTopic) -> Result<Option<Arc<SentrySchema>>, SchemaError> { | |||
There was a problem hiding this comment.
Returns an Arc to keep the critical section short.
Dav1dde
commented
Jul 19, 2024
| @@ -39,13 +40,13 @@ pub enum SchemaError { | |||
| #[derive(Debug, Default)] | |||
| pub struct Validator { | |||
| /// Caches the schema for given topics. | |||
| schemas: BTreeMap<KafkaTopic, Option<SentrySchema>>, | |||
| schemas: Mutex<BTreeMap<KafkaTopic, Option<Arc<SentrySchema>>>>, | |||
There was a problem hiding this comment.
Required to make this and the producer Send
Dav1dde
force-pushed
the
dav1d/store-metric-conc
branch
3 times, most recently
from
b812cfc
to
3940224
Compare
Dav1dde
commented
Jul 19, 2024
| @@ -332,3 +329,67 @@ impl Producer { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| struct Debounced { | |||
There was a problem hiding this comment.
Needed now because we need a Producer: Send and the atomic impl is a bit more elaborate
Dav1dde
force-pushed
the
dav1d/store-metric-conc
branch
from
3940224
to
8f610bb
Compare
jjbayer
approved these changes
Jul 19, 2024
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen the store is not being able to keep up if the processor gets parallelized too much. This switches the CPU heavy processing of the store to its own thread pool.
#skip-changelog