Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(metrics): Add simple test for metrics aggregator flush #3851

Merged
merged 1 commit into from
Jul 23, 2024
Merged

test(metrics): Add simple test for metrics aggregator flush #3851

merged 1 commit into from
Jul 23, 2024

Conversation

Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented Jul 23, 2024

Adds a simple test for the pop flush method of the metrics aggregator.

#skip-changelog

@Dav1dde Dav1dde requested a review from a team as a code owner July 23, 2024 10:20
@Dav1dde Dav1dde self-assigned this Jul 23, 2024
iambriccardo
iambriccardo approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@iambriccardo iambriccardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of tokio advance!

@Dav1dde Dav1dde enabled auto-merge (squash) July 23, 2024 10:24
@Dav1dde Dav1dde merged commit 3f03ac2 into master Jul 23, 2024
23 checks passed
@Dav1dde Dav1dde deleted the dav1d/test-aggregator branch July 23, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjbayer jjbayer jjbayer approved these changes

@iambriccardo iambriccardo iambriccardo approved these changes

Assignees

@Dav1dde Dav1dde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dav1dde @jjbayer @iambriccardo