feat(redis): Allow configuring Redis pools individually #3859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
commented
Jul 24, 2024
Comment on lines
+385
to
+390
| let pool = create_redis_pool(pool)?; | ||
| Ok(RedisPools { | ||
| project_configs: pool.clone(), | ||
| cardinality: pool.clone(), | ||
| quotas: pool.clone(), | ||
| misc: pool, |
There was a problem hiding this comment.
This is the part that's different from the first PR: we only create one pool, then clone it.
loewenheim
changed the title
Dav1dde
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt at #3843. Implements #3829.
This time around, if there is only one Redis pool configuration, we only create one pool and clone it 4 ways (instead of creating 4 identical pools like last time). This means that the case of only one configuration preserves the current behavior, modulo the bug fix related to
DEFAULT_MIN_MAX_CONNECTIONS.