ref(metrics): Remodel metric submission flow #3867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
dav1d/flushbuckets-perf
branch
4 times, most recently
from
5313173
to
8c70b12
Compare
Dav1dde
force-pushed
the
dav1d/flushbuckets-perf
branch
from
8c70b12
to
98f9d95
Compare
iambriccardo
approved these changes
Jul 26, 2024
| let mut buckets = match data { | ||
| MetricData::Parsed(buckets) => buckets, | ||
| MetricData::Raw(items) => { | ||
| let mut buckets = Vec::new(); |
There was a problem hiding this comment.
nit: can we lift this into a function that parses them? Might be more readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all the load of processing metrics from the project cache and move it to the processor.
We slowly moved more and more logic into the project cache, which over time became quite expensive to execute. Especially for heavily batched metrics. To alleviate this problem, the project cache only enriches messages with project information and dispatches based on this information instead of also dealing with filtering/validating metrics and rate limiting metrics.
Validation and rate limits are now enforced in the Processor.
The old flow for Metrics:
sequenceDiagram Endpoint->>Processor: ProcessMetrics Processor->>Project Cache: AddMetricBuckets activate Project Cache Note right of Project Cache: [check_buckets] Project Cache->>Aggregator: MergeBuckets deactivate Project Cache Aggregator->>Project Cache: FlushBuckets activate Project Cache Note right of Project Cache: [check_buckets] Project Cache->>Processor: EncodeMetrics deactivate Project Cache Processor->>Store: SendRequestThe new flow:
sequenceDiagram participant Endpoint participant Processor participant Project Cache participant Aggregator participant Store Endpoint->>Project Cache: ProcessMetrics Project Cache->>Processor: ProcessProjectMetrics activate Processor Note right of Processor: [check_buckets] Processor->>Aggregator: MergeBuckets deactivate Processor Aggregator->>Project Cache: FlushBuckets Project Cache->>Processor: EncodeMetrics activate Processor Note right of Processor: [check_buckets] Processor->>Store: SendRequest deactivate ProcessorBatched metrics just have a slightly adjusted flow, they go from the endpoint to the processor for parsing, then move forward with the same
ProcessMetricsflow.#skip-changelog