Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): Support booleans in metric extraction #3875

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Jul 29, 2024

Allows to specify boolean fields as source for metric tag values in
generic metric extraction. The values will be extracted as capitalized
"True" and "False" to match how tag values are converted by
LenientString in event payloads.

Numbers are still explicitly unsupported as they are a major footgun
with regards to cardinality.

Fixes getsentry/sentry#75072
#skip-changelog
cc @vgrozdanic

@jan-auer jan-auer requested a review from a team as a code owner July 29, 2024 11:24
@jan-auer jan-auer self-assigned this Jul 29, 2024
@jan-auer jan-auer enabled auto-merge (squash) July 29, 2024 11:32
@jan-auer jan-auer merged commit 24726ce into master Jul 29, 2024
27 checks passed
@jan-auer jan-auer deleted the feat/metric-xt-bool branch July 29, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: You can not group by a tag that has not been seen
2 participants