feat(process-value): Add object level trimming #3877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iambriccardo
commented
Jul 31, 2024
relay-event-derive/src/lib.rs
Outdated
| let mut field_attrs = parse_field_attributes(index, bi.ast(), &mut is_tuple_struct); | ||
| // In case we have `fake_trim` set on the type, we want to override this field attribute | ||
| // manually. | ||
| if type_attrs.fake_trim { |
There was a problem hiding this comment.
It would be nice not to use field_attrs and instead create a new type but it might make it a much bigger PR and maybe confuse whoever uses the Processor interface.
iambriccardo
changed the title
jjbayer
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
@iambriccardo could you please link this PR to the previous two attempts?
jjbayer
added a commit
that referenced
this pull request
Aug 2, 2024
This seems to not have solved the problem and introduced new failures. Reverts #3877
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an object-level trimming control, which works slightly differently from before. Instead of avoiding trimming altogether, this implementation performs all the traversal as if it were trimming but doesn't perform the actual trimming. This way, any arbitrary node in the traversal path can treat a child node with
trim = disabledas if it were trimmed, but its contents in reality are not.In our example, we want to limit an array of spans to 800 KiB, but we don't want the trimming to happen inside the span. Rather, we want to let the system trim the entire spans in the array. To achieve this, we had to implement this system in which a span signals how many bytes were used but no data is trimmed. Then, the array sees that the remaining size is 0 and will start dropping entire spans.
Closes: #3880