Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spool): Treat (key1, key2) and (key2, key1) as distinct stack keys #3881

Merged
merged 67 commits into from
Aug 13, 2024

Conversation

jjbayer
Copy link
Member

@jjbayer jjbayer commented Jul 31, 2024

#3863 features an optimization that treats project key pairs (key1, key2) and (key2, key1) as the same stack key. This keeps the number of entries in the priority queue minimal.

However, this prevents backward compatibility, because self-hosted users might still have existing DBs with two separate entries for the same key pair, and querying for both combinations is unnecessarily slow.

#skip-changelog

@jjbayer jjbayer marked this pull request as ready for review July 31, 2024 14:56
@jjbayer jjbayer requested a review from a team as a code owner July 31, 2024 14:56
Base automatically changed from feat/envelope-buffer to master August 1, 2024 06:07
Copy link
Member

@iambriccardo iambriccardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we might want to add a metric to measure how many times a combinations of the same projects is stored twice in the map.

@iambriccardo iambriccardo merged commit d5c5ad3 into master Aug 13, 2024
24 checks passed
@iambriccardo iambriccardo deleted the feat/envelope-buffer-own-key branch August 13, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants