feat(profiles): Add an optional client SDK field for Sample V2 format #3882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
approved these changes
Aug 1, 2024
Yes, definitely. |
phacops
changed the title
Zylphrex
added a commit
that referenced
this pull request
Aug 8, 2024
Similar to #3882, but for the existing formats. Extract the sdk info from the transaction event.
Zylphrex
added a commit
that referenced
this pull request
Aug 12, 2024
Similar to #3882, but for the existing formats. Extract the sdk info from the transaction event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to collect SDK name and version for continuous profiling. This will have an optional field for the SDK to pass this information.
It's meant to be compatible with
relay/relay-event-schema/src/protocol/clientsdk.rs
Line 22 in 72b5d37
serde.