fix(spans): Mark all fields untrimmable #3890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
commented
Aug 2, 2024
Comment on lines
+966
to
+967
| // The actual spans were not touched: | ||
| assert_eq!(trimmed_spans.as_slice(), &spans[0..8]); |
There was a problem hiding this comment.
This assertion fails without the changes to Span.
Dav1dde
approved these changes
Aug 2, 2024
Comment on lines
+966
to
+967
| // The actual spans were not touched: | ||
| assert_eq!(trimmed_spans.as_slice(), &spans[0..8]); |
Base automatically changed from
revert-3877-riccardo/fix/trimming-spans
to
master
August 2, 2024 09:49
jjbayer
force-pushed
the
fix/span-all-fields-safe
branch
from
4d95b34
to
524a971
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark all fields of a span as untrimmable to ensure that the span is either trimmed as a whole, or left intact.
This PR is a temporary fix until we have a better way to atomically trim / not trim PRs.
Note that when we trim a span from a transaction, no outcome is generated for the span.
Fixes #3880.