fix(metrics): Properly split large buckets repeatedly #3893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
commented
Aug 2, 2024
| let Range { start, end } = self.range.clone(); | ||
| SplitDecision::Split(n) => { | ||
| let Range { start, end } = self.range; | ||
| let at = start + n; |
| /// - `MoveToNextBatch` if the size budget cannot even hold the bucket name and tags. There is no | ||
| /// split, the entire bucket is moved. | ||
| /// - `Split(at)` if the bucket fits partially, the bucket should be split `at`. | ||
| /// - `Split(n)` if the bucket fits partially, the bucket should be split after `n` elements. |
There was a problem hiding this comment.
This change in documentation along with the remaining renaming should help to avoid this mistake going forward.
Dav1dde
approved these changes
Aug 2, 2024
loewenheim
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug in
BucketView::splitcauses an endless loop when splitting a bucket morethan once. Split did not honor the index of the last split and repeatedly
returned the same view on subsequent calls.
This function is used when sending global metric partitions, which causes high
request volume and backlogs when large buckets are ingested.