ref(feedback): clean up feedback topic rollout option #3916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
approved these changes
Aug 9, 2024
relay-server/src/services/store.rs
Outdated
| } else { | ||
| KafkaTopic::Events | ||
| }; | ||
| let topic = KafkaTopic::Feedback; |
There was a problem hiding this comment.
Can just inline this into the produce call:
self.produce(KafkaTopic::Feedback, message)
This was referenced Aug 9, 2024
aliu39
added a commit
to getsentry/sentry
that referenced
this pull request
Aug 12, 2024
Ref getsentry/relay#3916 Don't merge til removed from relay + option automator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref getsentry/sentry#66100
The topic and consumer has been deployed to all regions, and this option is 1.0 everywhere: https://github.com/search?q=repo%3Agetsentry%2Fsentry-options-automator%20topic.rollout&type=code.
After getsentry/self-hosted#3193 was merged, this is true for self-hosted as well. We don't have to worry about a migration there because this is the first PR enabling user feedback in SH.
Follow-up: remove from in order
#skip-changelog