Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(relay): Optimize normalization regexes #3921

Merged
merged 1 commit into from
Aug 13, 2024
Merged

ref(relay): Optimize normalization regexes #3921

merged 1 commit into from
Aug 13, 2024

Conversation

Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented Aug 13, 2024 •
edited
Loading

Optimizes memory footprint of regexes by:

  • Avoiding (unicde aware) case insensitive matching
  • Avoiding the use of unciode character sets like \d -> [0-9], \b -> (?-u:\b), \s -> (?-u:\s)

#skip-changelog

@Dav1dde Dav1dde requested a review from a team as a code owner August 13, 2024 08:19
@Dav1dde Dav1dde self-assigned this Aug 13, 2024
@Dav1dde Dav1dde enabled auto-merge (squash) August 13, 2024 08:25
@Dav1dde Dav1dde merged commit 6d01e72 into master Aug 13, 2024
25 of 26 checks passed
@Dav1dde Dav1dde deleted the dav1d/opt-re branch August 13, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iambriccardo iambriccardo iambriccardo approved these changes

Assignees

@Dav1dde Dav1dde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dav1dde @iambriccardo