feat(spooler): Add last_peek value in the priority #3922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
approved these changes
Aug 13, 2024
| @@ -20,6 +20,7 @@ | |||
| - Extract `user.geo.country_code` into span indexed. ([#3911](https://github.com/getsentry/relay/pull/3911)) | |||
| - Add `span.system` tag to span metrics ([#3913](https://github.com/getsentry/relay/pull/3913)) | |||
| - Extract client sdk from transaction into profiles. ([#3915](https://github.com/getsentry/relay/pull/3915)) | |||
| - Add `last_peek` field to the `Priority` struct. ([#3922](https://github.com/getsentry/relay/pull/3922)) | |||
There was a problem hiding this comment.
I don't think we need a changelog entry for this, it is a very technical description.
Comment on lines
+165
to
+176
| let Some(( | ||
| QueueItem { | ||
| key: stack_key, | ||
| value: _, | ||
| }, | ||
| _, | ||
| )) = self.priority_queue.peek() | ||
| else { | ||
| return Ok(None); | ||
| }; | ||
|
|
||
| let stack_key = *stack_key; |
There was a problem hiding this comment.
Untested:
Suggested change
| let Some(( | |
| QueueItem { | |
| key: stack_key, | |
| value: _, | |
| }, | |
| _, | |
| )) = self.priority_queue.peek() | |
| else { | |
| return Ok(None); | |
| }; | |
| let stack_key = *stack_key; | |
| let Some(( | |
| QueueItem { | |
| key: &stack_key, | |
| value: _, | |
| }, | |
| _, | |
| )) = self.priority_queue.peek() | |
| else { | |
| return Ok(None); | |
| }; |
There was a problem hiding this comment.
I tried already but it was not possible :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
last_peekfield to thePrioritystruct, which defines the priority of the stacks.The rationale behind the implementation is that assuming we have the same readiness and received_at time and keep peeking the stack, we will always get the same element. We want to avoid this and rather have a different element returned at every peek to avoid blocking stacks.
Closes: https://github.com/getsentry/team-ingest/issues/523