feat(spooler): Implement eviction algorithm for EnvelopeBuffer
#3932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iambriccardo
changed the title
iambriccardo
commented
Aug 16, 2024
| // elements from each popped stack. | ||
| for lru_item in lru { | ||
| if let Some(mut stack) = self.pop_stack(lru_item.0) { | ||
| stack.evict().await; |
There was a problem hiding this comment.
If we are using disk, it's not the most efficient thing to run a query for each project key pair but we can investigate the performance of this later on.
iambriccardo
commented
Aug 16, 2024
iambriccardo
commented
Aug 16, 2024
| @@ -105,15 +106,18 @@ struct EnvelopeBuffer<P: StackProvider> { | |||
| /// This indirection is needed because different stack implementations might need different | |||
| /// initialization (e.g. a database connection). | |||
| stack_provider: P, | |||
| /// The maximum number of stacks that can be evicted when low on memory. | |||
| max_evictable_stacks: usize, | |||
There was a problem hiding this comment.
We might want to have this defined as a percentage (since the buffer can grow a lot), but for now, we will remain with a static value.
iambriccardo
changed the title
EnvelopeBuffer
|
Closed in favor of #4014. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an eviction algorithm that can be triggered via the
evictmethod call on theEnvelopeBuffer. The eviction policy aims to evict all the envelope stacks that are not ready or have been stale for the longest time.The PR doesn't include the logic for triggering the eviction, since this is something that we can decide later on. Still, some possibilities include trying eviction via tickers that frequently monitor the capacity of Relay and evict data when in need.
Closes: https://github.com/getsentry/team-ingest/issues/518