Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): Add relay configuration for detecting canary #3938

Merged
merged 11 commits into from
Aug 27, 2024
Merged

feat(config): Add relay configuration for detecting canary #3938

merged 11 commits into from
Aug 27, 2024

Conversation

iambriccardo
Copy link
Member

@iambriccardo iambriccardo commented Aug 16, 2024 •
edited
Loading

This PR adds a new field in the Config to determine which instance of Relay is running. We could use such information to scope down even more whether some features are active or not.

Closes: https://github.com/getsentry/team-ingest/issues/262

@iambriccardo iambriccardo marked this pull request as ready for review August 26, 2024 11:14
@iambriccardo iambriccardo requested a review from a team as a code owner August 26, 2024 11:14
@iambriccardo iambriccardo changed the title feat(config): Add relay environment configuration feat(config): Add relay deployment configuration Aug 26, 2024
Dav1dde
Dav1dde reviewed Aug 26, 2024
View reviewed changes
Copy link
Member

@Dav1dde Dav1dde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted, would definitely not use deployment.

But we should still first answer the question if we even want this and if that, as noted in the issue itself.

relay-config/src/config.rs Outdated Show resolved Hide resolved
@iambriccardo iambriccardo changed the title feat(config): Add relay deployment configuration feat(config): Add relay configuration for detecting canary Aug 27, 2024
@iambriccardo iambriccardo merged commit 7da488e into master Aug 27, 2024
24 checks passed
@iambriccardo iambriccardo deleted the riccardo/feat/canary branch August 27, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dav1dde Dav1dde Dav1dde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iambriccardo @Dav1dde