feat(sentry): Add tags to sentry configuration #3944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iambriccardo
approved these changes
Aug 26, 2024
Dav1dde
reviewed
Aug 26, 2024
Dav1dde
changed the title
|
Hi @Dav1dde, @iambriccardo, can I do anything to get this PR merged ? |
Dav1dde
approved these changes
Sep 18, 2024
|
@JHeilCoveo sorry I was on vacation and somehow this fell through the cracks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have many regions for a given environment, when an issue arise it is impossible for us to know in which region the issue occurred as the only tag included in the sentry issue is the environment one.
This adds configurable tags in sentry configuration. Each event sent by Sentry relay will have those tags appended.
Fix #3842
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.