Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(project-config): Query project configs with revision #3947

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented Aug 26, 2024

Follow-up to to #3892, now also implements the revision fetching in the project config API.

Sentry does not need to be updated and this is not a breaking change and works with any combinations of Relays.

Extends the project config API with another field revisions which optionally contains the revisions for all requested public keys. If there are are revisions, the response is extended with a field unchanged which contains all project keys which were unchanged (have the same revision), similar to how pending is handled.

@Dav1dde Dav1dde requested a review from a team as a code owner August 26, 2024 12:54
@Dav1dde Dav1dde marked this pull request as draft August 26, 2024 12:55
@Dav1dde Dav1dde force-pushed the dav1d/rev-pc-api branch 2 times, most recently from f1c2a42 to de0e1f5 Compare August 26, 2024 13:34
@Dav1dde Dav1dde marked this pull request as ready for review August 26, 2024 13:38
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

relay-server/src/endpoints/project_configs.rs Show resolved Hide resolved
relay-server/src/services/project/state.rs Outdated Show resolved Hide resolved
relay-server/src/services/project_upstream.rs Show resolved Hide resolved
relay-server/src/services/project_upstream.rs Outdated Show resolved Hide resolved
@Dav1dde Dav1dde force-pushed the dav1d/rev-pc-api branch 2 times, most recently from 14b1a4e to dc64d1a Compare August 27, 2024 13:37
@Dav1dde Dav1dde merged commit c064654 into master Aug 28, 2024
24 checks passed
@Dav1dde Dav1dde deleted the dav1d/rev-pc-api branch August 28, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants