fix(spans): check sdk platform for user.geo.subregion tag #4023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
approved these changes
Sep 11, 2024
| let should_extract_geo = | ||
| event.context::<BrowserContext>().is_some() || MOBILE_SDKS.contains(&event.sdk_name()); | ||
| let should_extract_geo = (event.context::<BrowserContext>().is_some() | ||
| && event.platform.as_str() == Some("javascript")) |
There was a problem hiding this comment.
Couldn't this still be a javascript backend client? Or is python the only backend SDK that sets browser context?
There was a problem hiding this comment.
@jjbayer Yes but this is not a super common case, because most javascript backends have platform set to "node" instead of javascript. This is a pretty easy change to add, so I think we can see how much of an improvement it makes before moving onto more improvements.
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards getsentry/sentry#75230
This is an extension of this PR #4013
I assumed that Backend SDK transactions would not have a browser context, so i used that as a means to check if the project is a frontend project. Turns out, python SDKs still set browser context on the transaction (I guess this is the browser the user made the request from?). So to fix this, we can just check the platform directly as frontend is typically/always javascript.